Skip to content

Fix: concurrent NodePublishVolume calls could mount volume without certificates#211

Open
tpmdb wants to merge 1 commit intocert-manager:mainfrom
tpmdb:main
Open

Fix: concurrent NodePublishVolume calls could mount volume without certificates#211
tpmdb wants to merge 1 commit intocert-manager:mainfrom
tpmdb:main

Conversation

@tpmdb
Copy link
Copy Markdown

@tpmdb tpmdb commented May 1, 2026

This PR is for cert-manager/csi-driver#636.

I wasn't able to reproduce the bug, but with some help from Claude, this seems to be the likely cause.

When two concurrent NodePublishVolume requests arrive for the same volume ID while isReadyToRequest is true, a race condition allows the pod to receive a mounted but empty volume (no certificate files).

@cert-manager-prow cert-manager-prow Bot added the dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. label May 1, 2026
@cert-manager-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign wallrj for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow
Copy link
Copy Markdown
Contributor

Hi @tpmdb. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cert-manager-prow cert-manager-prow Bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 1, 2026
Signed-off-by: Tom Peterson <tom.peterson@mongodb.com>
@cert-manager-prow cert-manager-prow Bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant