Fix handling of decimal digits, following the authors style.#4
Open
xipasduarte wants to merge 4 commits intocesarandreu:masterfrom
Open
Fix handling of decimal digits, following the authors style.#4xipasduarte wants to merge 4 commits intocesarandreu:masterfrom
xipasduarte wants to merge 4 commits intocesarandreu:masterfrom
Conversation
Adds the decimal part of a number to the end of the comma separated integer number.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've seen that there was another Pull Request for this same issue, however I find it too far apart from the author's style and logic. For this reason I created the following for consideration.
Also, this allows for different decimal separators to be supplied by the user as parameters (not included in @kishore-narendran's proposal).