ENT-11481: Removed web server redirect from http to https - #1953
Merged
Conversation
aleksandrychev
requested review from
craigcomstock,
nickanderson and
olehermanse
September 29, 2025 14:38
nickanderson
left a comment
nickanderson
left a comment
Member
There was a problem hiding this comment.
I am not sure about this. It doesn't seem right.
Maybe it would be better to just not support the redirection.
Contributor
Author
yes, at least not in httpd config.. I will re-do this one and open additional in the MP. |
HTTP_HOST can be manipulated via Host header and for this reason http to https redirect will be handled on the UI. Ticket: ENT-11481 Signed-off-by: Ihor Aleksandrychiev <ihor.aleksandrychiev@northern.tech>
aleksandrychev
force-pushed
the
ENT-11481
branch
from
September 30, 2025 07:32
8b52ad5 to
ac7b17c
Compare
aleksandrychev
changed the title
Contributor
Author
|
@nickanderson I changed this one and added https://github.com/cfengine/mission-portal/pull/2906 |
craigcomstock
approved these changes
Sep 30, 2025
nickanderson
approved these changes
Sep 30, 2025
| # Force https with redirection | ||
| RewriteCond %{HTTPS} off | ||
| RewriteRule (.*) https://%{HTTP_HOST}%{REQUEST_URI} [R=301,L] | ||
|
|
Member
There was a problem hiding this comment.
So this drops all http -> https redirection from apache directly. Seems OK i guess as long as we prevent login and stuff on http.
Member
There was a problem hiding this comment.
It will be a HTML (JavaScript) redirect instead.
olehermanse
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTP_HOST can be manipulated via Host header and for this reason http to https redirect will be handled on the UI.
Ticket: ENT-11481
Signed-off-by: Ihor Aleksandrychiev ihor.aleksandrychiev@northern.tech
together: https://github.com/cfengine/mission-portal/pull/2906