ENT-13008: Added symlinks to CFEngine binaries in /usr/sbin for RHEL packages - #1963
Merged
Conversation
Contributor
Author
|
Manual testing on RHEL 7: Check that Check that symlinks are available in Check that symlinks are available in Test that man pages still work: Test that symlinks are removed: |
larsewi
marked this pull request as ready for review
October 2, 2025 09:52
larsewi
marked this pull request as draft
October 2, 2025 11:30
larsewi
force-pushed
the
symlink-migration
branch
3 times, most recently
from
October 2, 2025 11:52
fc13a4a to
333415f
Compare
Contributor
Author
|
@cf-bottom Jenkins with exotics please :) |
vpodzime
reviewed
Oct 2, 2025
vpodzime
left a comment
vpodzime
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me otherwise.
larsewi
force-pushed
the
symlink-migration
branch
from
October 2, 2025 13:03
333415f to
d5114f6
Compare
- Moved creation of CFEngine binary symlinks in `/usr/local/bin` to RPM spec files - Added new to CFEngine binary symlinks in `/usr/sbin` which is part of secure path RHEL uses a secure path when running sudo commands, which does not include `/usr/local/sbin`. This means cf-* binaries are not found when invoked via sudo. By adding symlinks to `/usr/sbin` (which is in the secure path), the binaries become accessible via sudo. We maintain backward compatibility by keeping the `/usr/local/sbin` symlinks as well. Ticket: ENT-13008 Changelog: Title Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
larsewi
force-pushed
the
symlink-migration
branch
from
October 2, 2025 13:03
d5114f6 to
4f113aa
Compare
|
Alright, I triggered a build: (with exotics) Jenkins: https://ci.cfengine.com/job/pr-pipeline/12796/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-12796/ |
craigcomstock
approved these changes
Oct 2, 2025
larsewi
marked this pull request as ready for review
October 3, 2025 08:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/usr/local/binto RPM spec files/usr/sbinwhich is part of secure pathMotivation: RHEL uses a secure path when running sudo commands, which does not include
/usr/local/sbin. This means cf-* binaries are not found when invoked via sudo. By adding symlinks to/usr/sbin(which is in the secure path), the binaries become accessible via sudo. We maintain backward compatibility by keeping the/usr/local/sbinsymlinks as well.Build (redhat only):
