ENT-12604: Quick and dirty janitorial check of build scripts - #1995
Merged
Conversation
larsewi
commented
Oct 21, 2025
larsewi
commented
Contributor
- Changed maintainer to packager@cfengine.com for consistency
- Fixed trailing spaces and missing trailing newline
- cfbuild-libgcc.spec: removed commented out code
- cfbuild-libxml2-mingw64-devel.install: removed excessive newline
- cfbuild-libxml2.spec: remove test for RHEL 4 & 5
- openldap/solaris/build: removed commented out code
- Removed unused patch
- Removed unused patches for pthreads-w32
- zlib/mingw/debian/rules: removed commented out code
- cache-sftp: removed commented out code
The other dependency packages use this email in the maintainer field of the deb packaging control file. Ticket: ENT-12604 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Ticket: ENT-12604 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Ticket: ENT-12604 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Ticket: ENT-12604 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
These versions of the RHEL platform are no longer supported. Ticket: ENT-12604 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Ticket: ENT-12604 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Ticket: ENT-12604 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Ticket: ENT-12604 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Ticket: ENT-12604 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Ticket: ENT-12604 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Contributor
Author
|
@cf-bottom Jenkins with exotics please :) |
|
Sure, I triggered a build: (with exotics) Jenkins: https://ci.cfengine.com/job/pr-pipeline/12859/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-12859/ |
larsewi
marked this pull request as ready for review
October 23, 2025 09:25
craigcomstock
approved these changes
Oct 24, 2025
craigcomstock
left a comment
craigcomstock
left a comment
Contributor
There was a problem hiding this comment.
looks good. hope it gets green without too much trouble.
Contributor
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.