ENT-12603: build-remote: adjust destination directory - #2009
Merged
Conversation
The previous path would cause build-remote to try to make the directory `/output/`. `/` is owned by root. Hence, permissions is denied. I think it makes more sense to put these files in `$BASEDIR/output/`. The transfer-results script is only used by build-remote. Hence, this change should be rather safe. Ticket: ENT-12603 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
larsewi
marked this pull request as ready for review
October 30, 2025 12:12
larsewi
changed the title
Contributor
Author
|
@cf-bottom Jenkins please :) |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/12903/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-12903/ |
olehermanse
approved these changes
Oct 31, 2025
aleksandrychev
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous path would cause build-remote to try to make the directory
/output/./is owned by root. Hence, permissions is denied. I think it makes more sense to put these files in$BASEDIR/output/.These scripts are only used by build-remote. Hence, this change should be rather safe.
Ticket: ENT-12603
Signed-off-by: Lars Erik Wik lars.erik.wik@northern.tech