Fixed version honoring EXPLICIT_VERSION when present - #2078
Merged
Conversation
Previously to master refactoring EXPLICIT_VERSION was used for VERSION if present. This was missed in the refactor and caused our new LTS 3.27.0 packages to have improper names including the sha as .x packages would. Ticket: ENT-13663 Changelog: none
olehermanse
marked this pull request as ready for review
January 9, 2026 17:52
olehermanse
approved these changes
Jan 9, 2026
Member
|
@cf-bottom jenkins, please |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/13291/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13291/ |
Contributor
Author
|
I think this change is correct. When explicit_version is specified the build gets: redhat_7 only build: https://ci.cfengine.com/job/testing-pr/6556/label=PACKAGES_x86_64_linux_redhat_7/console |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously to master refactoring EXPLICIT_VERSION was used for VERSION if present.
This was missed in the refactor and caused our new LTS 3.27.0 packages to have improper names including the sha as .x packages would.
Ticket: ENT-13663
Changelog: none