Fixed dotfile mv in pkg-build-deb picking up . and .. - #2164
Merged
Conversation
The glob pattern `.*` matches `.` and `..`, causing spurious warnings during tarball extraction. The `|| true` prevented the script from failing, but the warnings are noisy and confusing. Replaced with a loop that skips these special directory entries. Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Contributor
Author
|
@cf-bottom Jenkins please :) |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/13516/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13516/ |
olehermanse
approved these changes
Apr 14, 2026
craigcomstock
approved these changes
Apr 15, 2026
Member
|
@cf-bottom Please test this again in Jenkins :) |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/13531/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13531/ |
| mv $TD/*/.* $PKGDIR || true | ||
| # Also move dot files (.gitignore, etc.), skipping . and .. | ||
| for _dotfile in $TD/*/.*; do | ||
| case "${_dotfile##*/}" in |
Contributor
There was a problem hiding this comment.
interestingly, how is this bash expression different than basename? Using basename might be more immediately understandable to more folks.
Contributor
|
rhel 🔴 is a fluke: here is a retry: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.*inpkg-build-debmatches.and.., causing spurious warnings during tarball extraction in dependency packaging|| trueprevented the script from failing, but the warnings are noisy and confusing.and..🤖 Generated with Claude Code