ENT-13868: build-in-container.py now supports building windows packages - #2347
Merged
Conversation
larsewi
force-pushed
the
ENT-13868-windows-msi-build
branch
from
July 17, 2026 14:38
49b8c02 to
88b8e55
Compare
larsewi
changed the title
Ticket: ENT-13868 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
|
Thanks for submitting a PR! Maybe @craigcomstock can review this? |
larsewi
force-pushed
the
ENT-13868-windows-msi-build
branch
4 times, most recently
from
July 20, 2026 14:46
d39ba04 to
4dd51c7
Compare
Ticket: ENT-13868 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
larsewi
force-pushed
the
ENT-13868-windows-msi-build
branch
from
July 20, 2026 15:30
4dd51c7 to
e0bc3ff
Compare
Contributor
Author
|
@cf-bottom Jenkins please :) |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14243/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14243/ |
craigcomstock
approved these changes
Jul 20, 2026
| if [ -f /etc/cfengine-mingw-build-host.flag ]; then | ||
| if ! command -v wixl >/dev/null 2>&1 || ! command -v msiinfo >/dev/null 2>&1; then | ||
| sudo apt-get update | ||
| sudo DEBIAN_FRONTEND=noninteractive apt-get install -y wixl msitools |
Contributor
There was a problem hiding this comment.
yeah, this is the kind of duplication we need to fix. I made a ticket: https://northerntech.atlassian.net/browse/ENT-14330. I thought a ticket had been created previously but couldn't find it.
Contributor
Author
larsewi
marked this pull request as ready for review
July 21, 2026 10:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested:
msiinfo export)