CFE-4659: Added changelog-generator to cfengine-cli - #137
Merged
Conversation
SimonThalvorsen
force-pushed
the
CFE-4659
branch
2 times, most recently
from
May 28, 2026 12:28
76266ae to
2272521
Compare
olehermanse
reviewed
May 28, 2026
olehermanse
reviewed
May 28, 2026
olehermanse
reviewed
May 28, 2026
SimonThalvorsen
force-pushed
the
CFE-4659
branch
2 times, most recently
from
May 28, 2026 13:07
8fe3b86 to
eb094f3
Compare
olehermanse
self-requested a review
May 29, 2026 11:08
larsewi
reviewed
May 29, 2026
larsewi
left a comment
larsewi
left a comment
Contributor
There was a problem hiding this comment.
GJ 🚀 Some smaller comments
SimonThalvorsen
force-pushed
the
CFE-4659
branch
2 times, most recently
from
June 1, 2026 09:08
d8eb6b5 to
b00bb7b
Compare
olehermanse
changed the title
olehermanse
changed the title
SimonThalvorsen
changed the title
larsewi
reviewed
Jun 1, 2026
olehermanse
removed their request for review
June 1, 2026 18:27
Based on the previous changelog-scripts: https://github.com/cfengine/cf-bottom/blob/master/tom/changelog.py and https://github.com/cfengine/core/blob/master/misc/changelog-generator/changelog-generator Made with the intention to easily integrate with gh-action workflow in the future
larsewi
approved these changes
Jun 4, 2026
|
|
||
| if "Changelog" in trailers: | ||
| changelog_val = trailers["Changelog"] | ||
| if re.match(r"^Title[ .]*$", changelog_val, re.IGNORECASE): |
Contributor
There was a problem hiding this comment.
These anchors are implicit in re.match() and only adds noice
Suggested change
| if re.match(r"^Title[ .]*$", changelog_val, re.IGNORECASE): | |
| if re.match(r"Title[ .]*", changelog_val, re.IGNORECASE): |
Comment on lines
+37
to
+42
| def fetch_git_output(args): | ||
| return subprocess.run( | ||
| args, | ||
| stdout=subprocess.PIPE, | ||
| check=True, | ||
| ).stdout.splitlines(keepends=True) |
Contributor
There was a problem hiding this comment.
Suggested change
| def fetch_git_output(args): | |
| return subprocess.run( | |
| args, | |
| stdout=subprocess.PIPE, | |
| check=True, | |
| ).stdout.splitlines(keepends=True) | |
| def fetch_git_output(repo, args): | |
| path = os.path.join(os.getcwd(), repo) | |
| return subprocess.run( | |
| ["git", "-C", f"{path}"] + args, | |
| stdout=subprocess.PIPE, | |
| check=True, | |
| ).stdout.splitlines(keepends=True) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.