ENT-8118: Added os_version_minor sys variable (REFACTORED) - #5861
Merged
Conversation
victormlg
force-pushed
the
os_version_minor_2
branch
3 times, most recently
from
August 22, 2025 09:14
db68f92 to
9d77b8e
Compare
larsewi
reviewed
Aug 22, 2025
victormlg
force-pushed
the
os_version_minor_2
branch
2 times, most recently
from
August 22, 2025 09:45
0a4925b to
71c6080
Compare
Contributor
Author
|
@cf-bottom jenkins, please |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/12534/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-12534/ |
larsewi
requested changes
Aug 25, 2025
larsewi
left a comment
larsewi
left a comment
Contributor
There was a problem hiding this comment.
Some smaller comments. Always try avoid casting const pointers to non-const.
Ticket: ENT-8118 Signed-off-by: Victor Moene <victor.moene@northern.tech>
victormlg
force-pushed
the
os_version_minor_2
branch
from
August 27, 2025 09:33
71c6080 to
374dc49
Compare
Contributor
|
@cf-bottom jenkins with exotics please :) |
|
Sure, I triggered a build: (with exotics) Jenkins: https://ci.cfengine.com/job/pr-pipeline/12558/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-12558/ |
larsewi
approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.