CFE-3629: Unset C/CPP-flags to avoid repetition in compiler-flags - #6176
Merged
Conversation
|
Thanks for submitting a PR! Maybe @larsewi can review this? |
SimonThalvorsen
force-pushed
the
master
branch
6 times, most recently
from
June 18, 2026 11:55
5fc56c1 to
4c7df55
Compare
SimonThalvorsen
marked this pull request as ready for review
June 18, 2026 12:02
larsewi
approved these changes
Jun 19, 2026
Contributor
|
@cf-bottom Jenkins please :) |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/13962/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13962/ |
Contributor
Author
|
@cf-bottom Retry Jenkins please :) |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/13968/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13968/ |
SimonThalvorsen
force-pushed
the
master
branch
3 times, most recently
from
June 26, 2026 11:10
2168ca3 to
0bd9b90
Compare
…mpile-flags Ticket: CFE-3629 Changelog: None Signed-off-by: Simon Halvorsen <simon.halvorsen@northern.tech>
SimonThalvorsen
marked this pull request as draft
June 29, 2026 12:21
Contributor
|
@cf-bottom Jenkins please :) |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14054/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14054/ |
Add CF3_CFLAGS/DEBUG_CFLAGS to AM_CFLAGS; this Makefile was missed in the C-flags rework. Ticket: CFE-3629 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
larsewi
marked this pull request as ready for review
June 30, 2026 07:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: CFE-3629
Changelog: None