Skip to content

ENT-10961, CFE-1840: Added documentation on body fsattrs and the immutable constraint - #3403

Merged
olehermanse merged 1 commit into
cfengine:masterfrom
larsewi:immutable
Jul 4, 2025
Merged

ENT-10961, CFE-1840: Added documentation on body fsattrs and the immutable constraint#3403
olehermanse merged 1 commit into
cfengine:masterfrom
larsewi:immutable

Conversation

@larsewi

@larsewi larsewi commented Mar 7, 2025

Copy link
Copy Markdown
Contributor

Ticket: ENT-10961, CFE-1840

@nickanderson nickanderson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add history.

Comment thread reference/promise-types/files.markdown
Comment thread reference/promise-types/files.markdown Outdated
Comment thread reference/promise-types/files.markdown Outdated
Comment thread reference/promise-types/files.markdown Outdated
Comment thread reference/promise-types/files.markdown Outdated

@craigcomstock craigcomstock left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one typo

@larsewi
larsewi force-pushed the immutable branch 4 times, most recently from cea8867 to f06bab9 Compare May 26, 2025 12:14

@nickanderson nickanderson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but a question about what it means to clear the immutable bit multiple times.

Comment on lines +2794 to +2795
as short as possible. The immutable bit may be temporarily cleared multiple
times during a files promise.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this mean that it might be cleared multiple times during a files promise? Like cleared, re-applied, cleared, re-applied?

@larsewi larsewi May 28, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I mean is that if you have a file promise that for example contains both the content and the perms attribute. Then the immutable bit may be temporarily cleared while changing the perms and reapplied afterwards. Later when replacing $(this.promiser) with $(this.promiser).cfnew (containing new content) it may again be temporarily cleared and reapplied.

Ticket: ENT-10961, CFE-1840
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Co-authored-by: Nick Anderson <nick@cmdln.org>
@olehermanse

Copy link
Copy Markdown
Member

@cf-bottom jenkins, please

@cf-bottom

Copy link
Copy Markdown

@olehermanse
olehermanse merged commit 2cedf66 into cfengine:master Jul 4, 2025
2 checks passed
@larsewi
larsewi deleted the immutable branch July 25, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants