Reformatted some initial files with cfengine format - #3132
Merged
Conversation
olehermanse
commented
Apr 17, 2026
olehermanse
commented
Member
- Reformatted some initial files with cfengine format
- inventory/debian.cf: Manually adjusted 1 comment location
olehermanse
marked this pull request as ready for review
April 17, 2026 11:53
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
Member
Author
|
@cf-bottom Jenkins please :) |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/13545/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13545/ |
nickanderson
approved these changes
Apr 17, 2026
larsewi
reviewed
Apr 17, 2026
Comment on lines
+20
to
+21
| # array to populate | ||
| "$(linuxmint_info)", |
Contributor
There was a problem hiding this comment.
I think comments should stay on the side if that's where they where. At least, that's how black works
Member
Author
There was a problem hiding this comment.
Not really possible - comments are just comments and we render from syntax tree - whitespace is lost.
(We'd have to change the parser and architecture quite a bit to achieve that, and I don't think it's really worth it).
larsewi
approved these changes
Apr 17, 2026
Member
Author
|
RHEL 7 failure in Jenkins seem unrelated (connectivity issue). Acceptance tests on other platforms and GH Actions are green. |
Member
Author
|
Cherry-picks: #3157 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.