21 improve the landing page to clearly show what the company does#22
21 improve the landing page to clearly show what the company does#22
Conversation
…ilters and updated background images
…th backdrop filter
🦋 Changeset detectedLatest commit: 1381de8 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Maybe https://github.com/unplugin/unplugin-icons could be used like we did in another project we did
| } | ||
|
|
||
| :global(.orbit):hover > :global(*) { | ||
| animation-play-state: paused; |
There was a problem hiding this comment.
Nice! I didn't know that this can be done like this.
| left: 50%; | ||
| transform: translateX(-50%); | ||
| font-size: 0.9rem; | ||
| color: white; |
There was a problem hiding this comment.
Please use --color-white variable
| z.object({ | ||
| title: z.string(), | ||
| summary: z.string(), | ||
| buttonText: z.string(), |
There was a problem hiding this comment.
buttonText is a very generic label. What is the button going to be used for? Always use descriptive naming.
| @@ -1,6 +1,7 @@ | |||
| --- | |||
| title: Criteria Catalog | |||
| title: "Criteria Catalog 🗂️" | |||
There was a problem hiding this comment.
Why the English people are allowed to see emojis but the German speaking people arent?
| spotlightContent: "Join us in our mission to empower and connect the EdTech space with our products.", | ||
| spotlightActionConnect: "Connect", | ||
| spotlightActionEmpower: "Empower", | ||
| spotlightTitle: "Intelligent plugins in the field of education", |
There was a problem hiding this comment.
What does the word plugin mean here? Why are they intelligent? I think we should revert to the previous one.
There was a problem hiding this comment.
Maybe we can come up with a better one but in my opinion the previous one is a bit confusing to read and understand, the words "empower" and "connect" are not so straightforward.
There was a problem hiding this comment.
Maybe:
- Radiating knowledge
- Transmits knowledge
- Transports knowledge
| spotlightActionEmpower: "Empower", | ||
| spotlightTitle: "Intelligent plugins in the field of education", | ||
| spotlightContent: | ||
| "We are committed to developing innovative tools that empower educators, students, and developers in the field of educational technology.", |
There was a problem hiding this comment.
I think it's too long. Maybe try to optimize the existing one the make the message more clear? It can also be shortened:
"Join our mission to empower and connect the EdTech space, by ..."?
There was a problem hiding this comment.
I think this sentence "Join our mission to empower and connect the EdTech space" doesn't convey a clear message to people and might cause confusion
| <h1 slot="title">{messages.spotlightTitle}</h1> | ||
| <p slot="content">{messages.spotlightContent}</p> | ||
| <p slot="content" id="transition"> | ||
| Our products make education smarter, simpler, and more connected. Scroll down to see how ↓ |
There was a problem hiding this comment.
I think this makes the screen unnecessary cluttered and doesn't brings any value for the understanding.
| <h3>{product.data.title}</h3> | ||
| <p>{product.data.summary}</p> | ||
| <a href={product.translatedPath} class="button primary"> | ||
| {messages.spotlightActionEmpower} |
There was a problem hiding this comment.
I've the message spotlightActionEmpower is not used anymore, please remove it above.
| } | ||
| } | ||
|
|
||
| #scroll-button { |
There was a problem hiding this comment.
Please make a separate component out of it (like Orbiter).
| <div data-label="Message">💬</div> | ||
| <div data-label="Speed Up">🚀</div> | ||
| <div data-label="Solutions">💡</div> | ||
| <div data-label="Teaching">🧑🏫</div> |
There was a problem hiding this comment.
I like this, but also the other orbit should get labels and it should be translated to german. I think to make it translatable there needs to be a well thought out solution. Just using nanostores i18n is wrong for this use case as it is content.
|
I think it's also better to write the commit messages by hand. They are too long to keep an overview. Example: Bad: Good: |
| --color-white-97: hsl(from var(--color-white) h s calc(l * 0.97)); | ||
| --color-white: #f9f9f9; | ||
| --color-black: #333333; | ||
| --color-transition: #555; |
There was a problem hiding this comment.
You see the other colors are defined in another style. Please adapt.
…what-the-company-does
2 participants
No description provided.