Skip to content

23 add scroll button in the landing page#24

Merged
yixuanwu4 merged 10 commits intomainfrom
23-add-scroll-button-in-the-landing-page
Sep 3, 2025
Merged

23 add scroll button in the landing page#24
yixuanwu4 merged 10 commits intomainfrom
23-add-scroll-button-in-the-landing-page

Conversation

@yixuanwu4
Copy link
Contributor

No description provided.

@yixuanwu4 yixuanwu4 requested a review from openscript September 2, 2025 11:09
@yixuanwu4 yixuanwu4 linked an issue Sep 2, 2025 that may be closed by this pull request
@changeset-bot
Copy link

changeset-bot bot commented Sep 2, 2025

🦋 Changeset detected

Latest commit: 8b04c3e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a comment to this on the other pr.

</button>

<style>
#scroll-button {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this reference point to?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I understood correctly, but the scroll-button ID points to the button defined in this file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can reference it as button instead #scroll-button. #scroll-button will be global, while button will only influence the button in this file, what is more desired.

</button>

<style>
#scroll-button {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can reference it as button instead #scroll-button. #scroll-button will be global, while button will only influence the button in this file, what is more desired.

Copy link
Member

@openscript openscript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. Good job :)

@yixuanwu4 yixuanwu4 merged commit 0b57f9e into main Sep 3, 2025
1 check passed
@yixuanwu4 yixuanwu4 deleted the 23-add-scroll-button-in-the-landing-page branch September 3, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add scroll button in the landing page

2 participants