Fix fill color styles for GeoMap selected areas#171
Merged
Conversation
mistergone
approved these changes
Apr 1, 2019
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bug originally documented in #162 where selected states, metro areas, and counties on the geographic maps for Mortgage Performance Trends were the wrong color, obscuring the color representing delinquency rates for the selected area.
Additions
Removals
Changes
Testing
gulp build&&gulp watchFor cfgov-refresh:
cfgov-refresh/node_modulescfgov-refresh/node_modulesyarn run gulp build./runserver.shand visit http://localhost:8000/data-research/mortgage-performance-trends/mortgages-90-or-more-days-delinquent/ and select different areas of the map using the Select dropdownscfpb-chart-builderfromnode_modulesagain and re-install the published package withyarn add cfpb-chart-builder@v5.1.2Screenshots
Demo page in this repo:
cfgov-refresh:
Notes
Todos
Checklist