(DO NOT MERGE) pointing to current DSR styles#2
Draft
flacoman91 wants to merge 1 commit into
Draft
Conversation
flacoman91
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proof of concept to demonstrate how to use DSR minimally.
Without the fix in https://github.com/cfpb/design-system-react#chore/fix-slug-component-578 the styles for the heading and button aren't appearing
They're working in storybook and our other apps because we import the whole kitchen sink, ie.
Full DS CSS — import '@cfpb/cfpb-design-system/dist/index.css'
Complete styling, but heavy if you only need buttons/links
It looks like:
Pointing to the fixed heading and button references in the PR, it looks like
