fix(mlar): change MLAR file format, fix 2017 MLAR downloads#2571
Merged
fix(mlar): change MLAR file format, fix 2017 MLAR downloads#2571
Conversation
After searching for MLAR files from each year, open them and confirm they're not empty and are MLAR-ish (lots of pipes in the file). Fixes #2522
MLAR files are supposed to be .txt files and not .csv files. Their contents are pipe-delimited text. Fixes #2569
2017 has no `institution.lei` value so use the normalized institution ID when interpolating the download file name. Fixes #2570
Contributor
|
Let's wait to merge this in till ya get back. |
contolini
force-pushed
the
2522-test-mlar-downloads
branch
from
0de47c6 to
e99bab0
Compare
billhimmelsbach
approved these changes
Apr 9, 2026
Contributor
billhimmelsbach
left a comment
billhimmelsbach
left a comment
There was a problem hiding this comment.
Looks good! Let me know how ya wanna handle the announcement/news and update?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
.csvto.txtTesting
ModifiedLAR.spec.jscypress tests should pass.Notes
Screenshot