fix(cache): replace hardcoded asset preload URLs with source URLs

[contolini]

Vite replaces the URLs at build time with hashed minified versions.

See https://vite.dev/guide/assets.html
See https://vite.dev/guide/#index-html-and-project-root

Changes

• Replace hardcoded USWDS asset URLs with their source URLs.

Testing

1. Run yarn build and yarn start locally and check out the generated index.html file in the /dist dir.

[billhimmelsbach]

Thanks for the fix! Also... I put it up on staging and found some weird behaviors maaaaybe?

Looks like uswds.min.js gets downloaded twice maybe?

First Load

Second Load

The uswds.min.js that is served from the disk cache is yours, but then it's still getting imported again over here in Header.jsx which is the one served from the memory cache.

Also, I'm not sure if the uswds-init.min.js is actually be preloaded? Looks like it's being served from the memory cache from the Header.jsx import instead of from the preload. Here's what the preload looks like, looks like in the index:

Mind taking a quick peek? We can always just remove the preloads and see if it hits our lighthouse scores still, but maybe see if it's a quick fix?

[contolini]

Lol okay how do you feel about just deleting the two preloads? It feels so dirty hardcoding the hashed filename into the HTML file. On staging, their deletion bumps the homepage from a 95 lighthouse score to a 98 so hey that's a success?

before	after

I tried modulepreload over in 02f91f0 but it had no effect due to the structure of our app.

[billhimmelsbach]

Yeah, let's remove them for now! 🚀

[contolini]

Yeah, let's remove them for now! 🚀

K they dead 84f9b59

[billhimmelsbach]

Looks good! Good riddance!