Open
Conversation
…te code to remove async/await where possible/appropriate. closes cfpb#275
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
jcadam14
reviewed
Feb 10, 2025
Contributor
jcadam14
left a comment
There was a problem hiding this comment.
This looks good. We have some potential downstream impacts in that other repos are dependent on the filing-api and I know the cleanup repo uses the session engine for db connections so we'll need to coordinate this merge with that so nothing breaks. I might wait to merge this into main once we get the Pypi go ahead so I can make sure a better versioning concept is applied, which will make it easier to deal with repos dependent on this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove async driver, associated libraries and update code to remove async/await where possible/appropriate.
closes #275