fix(agents): align taizi and liubu SOULs with subagent flow#285
Open
luoyanglang wants to merge 1 commit intocft0808:mainfrom
Open
fix(agents): align taizi and liubu SOULs with subagent flow#285luoyanglang wants to merge 1 commit intocft0808:mainfrom
luoyanglang wants to merge 1 commit intocft0808:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue: Related to #251 / #246 / #274 — taizi and liubu still instruct agents to use
sessions_sendon paths that are already configured for subagent chainingType: Bug Fix
Severity: Medium
This PR aligns the remaining taizi/liubu SOUL instructions with the subagent flow that was already adopted in
fe7c06cfor zhongshu/menxia/shangshu. It removes stale guidance that still sends agents down the oldersessions_sendpath, which is more brittle and matches the user reports about "中书省不在线" / "只能太子可用".Root Cause
After
fe7c06c, the three-province chain already moved to subagent calls, but taizi and liubu SOUL files still told agents to usesessions_send.agents/taizi/SOUL.md:67-68still said to send the task to zhongshu viasessions_sendagents/taizi/SOUL.md:92still assumed the final handoff would come back viasessions_sendagents/groups/liubu.md:29and each liubu SOUL still told execution agents to report back to shangshu withsessions_sendagents/shangshu/SOUL.md:3-5already defines shangshu as a subagent caller, andinstall.sh/install.ps1already grant the necessarysubagents.allowAgentspermissionsSo the repository ended up with a mixed flow:
taizi -> sessions_send -> zhongshuzhongshu -> subagent -> menxia/shangshuliubu -> sessions_send -> shangshuThat inconsistency keeps steering agents toward the older and more failure-prone path even though the project is already configured for subagent chaining.
Fix Description
Changed files:
agents/taizi/SOUL.md:67-68— replace the zhongshu handoff instruction with a subagent callagents/taizi/SOUL.md:92— update the completion wording so taizi expects the full zhongshu -> menxia -> shangshu chain to return a final resultagents/groups/liubu.md:29— replace the stalesessions_sendreturn step with direct subagent return wordingagents/hubu/SOUL.md:3-5,40— mark hubu as a shangshu subagent and remove the oldsessions_sendreturn instructionagents/libu/SOUL.md:3-5,40— mark libu as a shangshu subagent and remove the oldsessions_sendreturn instructionagents/bingbu/SOUL.md:3-5,40— mark bingbu as a shangshu subagent and remove the oldsessions_sendreturn instructionagents/xingbu/SOUL.md:3-5,40— mark xingbu as a shangshu subagent and remove the oldsessions_sendreturn instructionagents/gongbu/SOUL.md:3-5,40— mark gongbu as a shangshu subagent and remove the oldsessions_sendreturn instructionagents/libu_hr/SOUL.md:3-5,40— mark libu_hr as a shangshu subagent and remove the oldsessions_sendreturn instructionRationale:
agents/shangshu/SOUL.mdsubagents.allowAgentspermissions already shipped by the install scriptsTest Results
rg -n "sessions_send" agentssessions_send; only explicit "not sessions_send" guidance remains in the subagent-based SOULsgit diff --checkDisprove Analysis
是否已有其他地方修复
I checked the earlier fix commit
fe7c06cand it only updatedagents/zhongshu/SOUL.md,agents/menxia/SOUL.md, andagents/shangshu/SOUL.md. The stale taizi/liubu instructions were still present onupstream/mainbefore this PR.影响范围
This change is limited to SOUL prompt instructions. It does not change Python code, dashboard APIs, install logic, or the kanban state machine. The behavioral impact is intentionally narrow: steer the agents onto the already-configured subagent path.
边界情况
I specifically checked that the install scripts already allow the required subagent calls:
taizi -> zhongshushangshu -> hubu/libu/bingbu/xingbu/gongbu/libu_hrSo this PR does not introduce a new permission dependency; it only aligns the prompts with existing configuration.
已知局限
This does not claim to fully solve the OpenClaw-side
sessions_sendregressions discussed in #274. It only removes stale Edict prompt instructions that continue to depend on that brittle path.Checklist
Found during routine triage. Happy to adjust if you prefer to keep a different agent-to-agent pattern here.