This repository was archived by the owner on Sep 21, 2021. It is now read-only.
Fix bugs in cleanText() and wordCount(), add some tests#12
Closed
antislice wants to merge 6 commits intocgiffard:masterfrom
Closed
Fix bugs in cleanText() and wordCount(), add some tests#12antislice wants to merge 6 commits intocgiffard:masterfrom
antislice wants to merge 6 commits intocgiffard:masterfrom
Conversation
Fixed: - words with an apostrophe counted as a single word - counting empty string after a period as a word
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made some editorial decisions, mostly around how hyphenated words and email addresses should be handled. The behavior should be all documented in the mocha tests. This also resolves the issues brought up in PRs #9 and #11.