feat: add timeout to authenticated api endpoint#2001
Open
mxatmx wants to merge 1 commit intocgwire:mainfrom
Open
feat: add timeout to authenticated api endpoint#2001mxatmx wants to merge 1 commit intocgwire:mainfrom
mxatmx wants to merge 1 commit intocgwire:mainfrom
Conversation
Member
|
Thank you for your improvement. One minor drawback: 10 seconds might not be enough. A brief network interruption (VPN, mobile network, or cold restart) could cause the user to be disconnected. Would a 20 or 30 second delay, or a single retry before the USER_LOGIN_FAIL error, be a good trade-off? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The authenticated API can hang indefinitely.
Solution
Adds a 10 second timeout to the
/api/auth/authenticatedendpoint.