v1.7.0: remove unreliable price data#17
Merged
Merged
Conversation
Removed: - All MSRP price fields (msrp_usd + localized msrp_eur/gbp/inr/aed/aud/ cad/vnd/chf) from the schema and stripped from 468 cameras. The data was sparse (~36%, single-currency, undated) and unreliable — omitting it is more honest than publishing inaccurate prices. Changed: - Clarified that video.streams[] describes stream capabilities, distinct from configs.frigate.* (the RTSP URLs to use) — they complement. Docs: README schema table + roadmap updated; JSON-Schema-in-CI marked done.
Owner
Author
|
closes #16 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed:
Changed:
Docs: README schema table + roadmap updated; JSON-Schema-in-CI marked done.
What does this PR do?
Checklist
For new cameras
cameras/<brand-slug>/<model-slug>.jsonidis a unique lowercase slug matching the file pathbrand,model,type,resolutionare all presentsources(manufacturer datasheet or reputable retailer)npm run buildpasses locally with no errorsFor corrections
npm run buildpasses locally with no errorsFor schema / tooling changes
npm run build)docs/glossary.mdif new fields were addedSource(s)
Notes