Make use of offset argument to improve performance#30
Make use of offset argument to improve performance#30wasamasa wants to merge 2 commits intoch11ng:masterfrom
Conversation
This builds upon ch11ng#2 which did most of the work. For some reason the original PR did hardcode the offset to 0 and instead created copies of the array with an increasing offset instead.
|
Hi, I deployed EXWM built on this branch via my custom channel in Guix. EXWM works fine and seems to start a few seconds faster. Thank you for maintaining this great little library! Kind regards |
|
Hi, This PR has another positive side effect. Aside from the speed up, it fixed an annoying problem I've had with my multi-head setup for a while. Previously, my third monitor would only come up about sixty percent of the time, although I'm not sure how to explain that interaction with Kind regards |
|
@Stebalien Have you seen this patch? What do you think about it? |
|
This seems completely reasonable. (and @wasamasa has his papers in order, unless I'm mistaken). |
|
But the fact that emacs-exwm/xelb isn't a fork is really annoying when it comes to porting PRs... |
Before Emacs 29, when-let (and friends) lived in subr-x, which isn't autoloaded. * xcb-types.el: require subr-x before Emacs 29 (fixes emacs-exwm/exwm#130).
4 participants
This builds upon #2 which did most of the work. For some reason the original PR did hardcode the offset to 0 and instead created copies of the array with an increasing offset instead.
Before: Initiating a X connection with
xcb:connecttook between 2.4 and 2.9sAfter: Initiating a X connection with
xcb:connectnow takes 0.31 to 0.33s