Reverts changes to sajson::globals_struct::parse_flags#54
Open
wojdyr wants to merge 2 commits intochadaustin:masterfrom
Open
Reverts changes to sajson::globals_struct::parse_flags#54wojdyr wants to merge 2 commits intochadaustin:masterfrom
wojdyr wants to merge 2 commits intochadaustin:masterfrom
Conversation
…gs." This reverts commit 55b448b. That change was for chadaustin#48, but it broke compilation with recent GCC.
it reverts part of eda4eae removing a couple constexpr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully fixes #48
Currently, sajson fails to compile with GCC. Previously, a problem with VS2015 were reported.
This PR reverts parse_flags to how it was defined until 2020.