fix: use TestClient in default_app integration test so lifespan runs#15
Merged
yoonji57 merged 6 commits intoMar 18, 2026
Merged
Conversation
- Skip expired EXPIREAT entries during replay. - Append only on successful write results and flush per entry. - Enforce EXPIREAT expires_at to remain a float. Made-with: Cursor
Remove conflict markers from main and integration tests. Made-with: Cursor
- Set app.state.command_executor only when provided so lifespan can set it. - Always call store.expireat on replay so expired keys are removed. - Update persistence unit test expectation. Made-with: Cursor
request() with ASGITransport does not trigger lifespan; TestClient does. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
equest(app, ...).
Why
equest()\ with httpx ASGITransport does not run the app lifespan, so \�pp.state.command_executor\ was never set and the test got 500.
Tests
Docs updated
Known limitations
Made with Cursor