feat(store): custom hash table 기반 저장소로 교체#19
Merged
Conversation
- FNV-1a open addressing hash table 구현 - Store API와 TTL semantics는 유지한 채 data_map, expire_map 교체 - collision, probing, tombstone, resize, stress, regression 테스트 추가
- replace Store data_map and expire_map initialization from dict to HashTable - align store implementation with the hash table migration already reflected in tests - fix failing store core tests caused by the dict/HashTable mismatch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Store내부data_map,expire_map을 Pythondict에서 직접 구현한HashTable로 교체했습니다.GET/SET/DEL/EXPIRE/TTL/PERSIST의 기존 store semantics와 coarse lock 동작이 새 저장 구조에서도 유지되도록 연결했습니다.expires_at기반)으로 정리했습니다.Why
Tests
$env:PYTHONPATH='.'; pytest tests/unit/test_hash_table.py tests/unit/test_store_core.py tests/unit/test_store_expiration.py(18 passed)mypy app/core/hash_table.py app/core/store.py실행 시 현재 변경 파일이 아닌app/core/lock.py의 기존LockType반환 타입 오류로 실패ruff는 현재 로컬 환경에 설치되어 있지 않아 실행하지 못했습니다Docs updated
docs/02-architecture.md: AOF persistence 계약을 optional이 아닌 always-on 기준으로 정리했습니다.docs/04-development-guide.md: AOF/replay 검증 기준과 persistence 브랜치 초점을 업데이트했습니다.docs/06-testing-playbook.md: recovery/replay 테스트 책임과expires_at기준 검증 규칙을 명시했습니다.Known limitations