Skip to content

fix quality checks#21

Merged
SISUinSea merged 2 commits into
chore/devfrom
fix/quality-check
Mar 18, 2026
Merged

fix quality checks#21
SISUinSea merged 2 commits into
chore/devfrom
fix/quality-check

Conversation

@SISUinSea
Copy link
Copy Markdown
Collaborator

What changed

  • Fixed the RESP parser input typing so mypy app accepts the actual buffered stream used by the TCP server.
  • Added a small protocol-based stream interface in the RESP parser instead of relying on the narrower BinaryIO type.
  • Applied Ruff formatting to the files that were failing ruff format --check ..

Why

  • Quality checks were failing for two separate reasons: one real type mismatch in the RESP parsing path, and a few files that were only out of format.
  • The type error came from app/protocol/resp_server.py passing self.rfile into parse_command_frame(...) while the parser signature required BinaryIO, which was stricter than the stream object provided by socketserver.

Tests

  • automated:
    • ./.venv/bin/ruff check .
    • ./.venv/bin/ruff format --check .
    • ./.venv/bin/mypy app
  • manual smoke:
    • Not run for this change. This PR only fixes static quality checks and formatting.

Docs updated

  • No docs updated.
  • This change does not alter the documented HTTP or RESP contracts.

Known limitations

  • No behavioral changes were made beyond fixing the static typing contract for the RESP parser input.
  • PR was prepared from codex/fix/quality-check and should target chore/dev.

@SISUinSea SISUinSea merged commit 4a2a5b2 into chore/dev Mar 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant