Skip to content

fix(skill): align telemetry dispatch and field name with server #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lxcong merged 1 commit into from
May 14, 2026
Merged

fix(skill): align telemetry dispatch and field name with server #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions skills/agentkey/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,9 @@ The script may print **two kinds of lines** (in any order):
- **Telemetry line** (zero or one):
- `TELEMETRY <event> <key=value> ...` → forward via MCP, silently and best-effort:
```
execute_tool(name="agentkey_internal", params={
agentkey_internal({
path: "telemetry/event",
params: { event: "<event>", props: { /* parsed key=value pairs */ } }
params: { event: "<event>", properties: { /* parsed key=value pairs */ } }
})
```
- If the tool does not exist or fails, **ignore completely** — never surface a telemetry error to the user.
Expand Down Expand Up @@ -86,9 +86,9 @@ If a Bash tool is available (Claude Code etc.), use `AskUserQuestion`. Otherwise

After running **Step C**, dispatch (silently, ignore failures):
```
execute_tool(name="agentkey_internal", params={
agentkey_internal({
path: "telemetry/event",
params: { event: "upgrade_decision", props: {
params: { event: "upgrade_decision", properties: {
from_version: "<old>", to_version: "<new>", choice: "accept_once"
}}
})
Expand All @@ -99,9 +99,9 @@ If a Bash tool is available (Claude Code etc.), use `AskUserQuestion`. Otherwise

After the action, dispatch (silently, ignore failures):
```
execute_tool(name="agentkey_internal", params={
agentkey_internal({
path: "telemetry/event",
params: { event: "upgrade_decision", props: {
params: { event: "upgrade_decision", properties: {
from_version: "<old>", to_version: "<new>", choice: "accept_always"
}}
})
Expand All @@ -127,9 +127,9 @@ If a Bash tool is available (Claude Code etc.), use `AskUserQuestion`. Otherwise

Map the choice for telemetry: With-Bash uses `SNOOZED_LEVEL` (`1` → `snooze_1d`, `2` → `snooze_2d`, `3` → `snooze_7d`); No-Bash uses `snooze_1d` (no persisted level). Then dispatch (silently, ignore failures):
```
execute_tool(name="agentkey_internal", params={
agentkey_internal({
path: "telemetry/event",
params: { event: "upgrade_decision", props: {
params: { event: "upgrade_decision", properties: {
from_version: "<old>", to_version: "<new>", choice: "<mapped choice>"
}}
})
Expand All @@ -140,9 +140,9 @@ If a Bash tool is available (Claude Code etc.), use `AskUserQuestion`. Otherwise

After the action, dispatch (silently, ignore failures):
```
execute_tool(name="agentkey_internal", params={
agentkey_internal({
path: "telemetry/event",
params: { event: "upgrade_decision", props: {
params: { event: "upgrade_decision", properties: {
from_version: "<old>", to_version: "<new>", choice: "never_ask"
}}
})
Expand All @@ -166,9 +166,9 @@ On success: tell the user "✓ AgentKey updated to v\<new\>." On failure: show t

After the `npx` command returns, dispatch (silently, ignore failures):
```
execute_tool(name="agentkey_internal", params={
agentkey_internal({
path: "telemetry/event",
params: { event: "upgrade_result", props: {
params: { event: "upgrade_result", properties: {
from_version: "<old>", to_version: "<new>",
status: <"ok" if npx succeeded else "fail">,
error_class: <one of "network" | "npx_failed" | "permission" | "unknown" if status=="fail" else null>
Expand Down
Loading