quotes: Fix quotes on ints and floats#125
Open
justinvreeland wants to merge 1 commit intochainguard-dev:mainfrom
Open
quotes: Fix quotes on ints and floats#125justinvreeland wants to merge 1 commit intochainguard-dev:mainfrom
justinvreeland wants to merge 1 commit intochainguard-dev:mainfrom
Conversation
justinvreeland
force-pushed
the
jvreeland-fix-quotes
branch
from
519067d to
e2e07a0
Compare
If the file that is supposed to be quoted is a float or int convert it to a string so that we can apply DoubleQuotes. Most fields in melange configs are strings anyway for replacements to work.
justinvreeland
force-pushed
the
jvreeland-fix-quotes
branch
from
e2e07a0 to
67371a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the file that is supposed to be quoted is a float or int convert it to a string so that we can apply DoubleQuotes. Most fields in melange configs are strings anyway for replacements to work.
Fixes: #100