Skip to content

Change all fixed fee to dynamic relay fee based calculation in functional tests#399

Merged
azuchi merged 1 commit intochaintope:masterfrom
Naviabheeman:ImproveFeePidInFunctionalTests
Mar 26, 2026
Merged

Change all fixed fee to dynamic relay fee based calculation in functional tests#399
azuchi merged 1 commit intochaintope:masterfrom
Naviabheeman:ImproveFeePidInFunctionalTests

Conversation

@Naviabheeman
Copy link
Copy Markdown
Contributor

this is the log from CI failure :

 test  2026-03-24T18:55:27.247000Z TestFramework (DEBUG): Node3 utxo count: 7064 
 test  2026-03-24T18:55:27.247000Z TestFramework (INFO): Iteration 38, generating 2500 transactions [9, 2, 0] 
 node3 2026-03-24T18:55:27.249660Z Received a POST request for / from 127.0.0.1:49594 
 node3 2026-03-24T18:55:27.249735Z ThreadRPCServer method=signrawtransactionwithwallet user=__cookie__ 
 test  2026-03-24T18:55:27.251000Z TestFramework (ERROR): JSONRPC error

Traceback (most recent call last):

  File "/Users/runner/work/tapyrus-core/tapyrus-core/test/functional/test_framework/test_framework.py", line 179, in main
    self.run_test()
  File "/Users/runner/work/tapyrus-core/tapyrus-core/test/functional/feature_dbcrash.py", line 240, in run_test
    self.generate_small_transactions(self.nodes[3], 2500, utxo_list)
  File "/Users/runner/work/tapyrus-core/tapyrus-core/test/functional/feature_dbcrash.py", line 210, in generate_small_transactions
    node.sendrawtransaction(tx_signed_hex)
  File "/Users/runner/work/tapyrus-core/tapyrus-core/test/functional/test_framework/coverage.py", line 52, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/Users/runner/work/tapyrus-core/tapyrus-core/test/functional/test_framework/authproxy.py", line 138, in __call__
    raise JSONRPCException(response['error'])
test_framework.authproxy.JSONRPCException: dust (code 64) (-26) 

The test failed because one of the transactions created by the test case has an output below dust threshold. TO avoid this, the test case is updated to set the minimum output based on the nodes relay fee rate.
Other tests which have fixed fee are changed to use the same approach.

@azuchi azuchi merged commit b7b77f6 into chaintope:master Mar 26, 2026
9 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants