Handle Finally Block When Jitting a loop in a Generator or Async function

[rhuanjl]

The OpCode TryFinallyWithYield is intended for Finally {} blocks where either the try or finally statement contains a Yield or Await. BUT was being used for all Finally {} blocks occurring in Generator or Async functions.

This OpCode is not implemented in the JIT. This results in an Abort when jitting a Generator or async function (or a loop inside a generator or async function) that contained a finally block.

The for...of construction includes an implicit finally block, it was the trigger for the Abort in issue 7034.

As we currently only try and Jit loops inside Async/Generator functions that do not contain Yield/Await, nothing we currently Jit ought to need the TryFInallyWithYield OpCode. Fix the issue by detecting when a Try/Finally statement actually contains a Yield or Await and only using the TryFinallyWithYield OpCode in those cases (Which are not due to be Jitted anyway), in cases without Yield/Await use the alternative Opcode TryFinally (which the Jit does support).

Fix:#7016
Fix:#7034

[rhuanjl]

@ppenzin I saw a bug I ought to fix, please could you review it?

[ppenzin]

Seems to be relatively straight-forward, sorry about the delay.

[ShortDevelopment]

@rhuanjl Nice addition!
Just a small note regarding the closing syntax: GitHub will only close the linked issue if you replace the : with a blank .

EDIT: Wrong, GitHub just wanted an additional space... (Fix: #abc)

[rhuanjl]

@rhuanjl Nice addition! Just a small note regarding the closing syntax: GitHub will only close the linked issue if you replace the : with a blank with each issue prefixed by one of the possible keywords like so:

Fix #abc
Fixes #abc

Interesting - I wonder if that has changed or if it's just too long since I did it.... I'm sure I used to put a : in there maybe Fix: #num works

[ShortDevelopment]

Oh, actually you are right; You can use a colon if you also include a space!

According to the docs

The keywords can be followed by colons or in uppercase. For example: Closes: #10, CLOSES #10, or CLOSES: #10.

(Never saw that note)