Remove unnecessary String re-implementations from PAL#7049
Closed
rhuanjl wants to merge 3 commits intochakra-core:masterfrom
Closed
Remove unnecessary String re-implementations from PAL#7049rhuanjl wants to merge 3 commits intochakra-core:masterfrom
rhuanjl wants to merge 3 commits intochakra-core:masterfrom
Conversation
rhuanjl
force-pushed
the
PalStringcleanup
branch
from
a9780d3 to
c5e86d9
Compare
jobayer110
approved these changes
Dec 8, 2025
Collaborator
Author
|
@jobayer110 this PR currently is not useful, I'm not sure what your review indicates, but I've closed it for now as it doesn't do the job. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove some unnecessary string functions from PAL; this may fix a build break on Arch Linux.
EDIT: This is currently just an experiment trying to help a friend build CC for Arch linux - this is not yet a sufficient fix