Knn #12
Open
Knn #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o bst Merging branch bst.
…o bst sdf building a binary search tree.
…ctures into traversal-bst g g Lines starting with '#' will be ignocquire post_order_trav. red, and an empty message aborts
nhuntwalker
reviewed
Feb 22, 2017
.travis.yml
Outdated
| # command to install dependencies | ||
| install: | ||
| - pip install -e .[test] | ||
| # - pip install coveralls |
.travis.yml
Outdated
| script: | ||
| - py.test --cov=. --cover-report term-missing | ||
|
|
||
| # notifications |
src/knn.py
Outdated
| self.data = data | ||
| if k > len(data) or type(k) is not int or k <= 0: | ||
| raise ValueError("The number of neighbors to predict against must be an integer greater than 0 and less than size of data.") | ||
| self.k = 5 |
There was a problem hiding this comment.
Why set self.k if you have it coming into the method as an optional parameter
| for data_idx in range(len(self.data)): | ||
| squares_sum = 0.0 | ||
| for item_idx in range(len(eval_item)): | ||
| squares_sum += (eval_item[item_idx] - self.data[data_idx][item_idx]) ** 2 |
There was a problem hiding this comment.
You're missing out on the power of numpy or pandas to perform math operations across an entire data set. The distance calculation could be one-lined.
| raise ValueError("The number of neighbors to predict against must be an integer greater than 0 and less than size of data.") | ||
| self.k = 5 | ||
|
|
||
| def predict(self, evals, k=None): |
There was a problem hiding this comment.
Why are you providing k here? You set it when you initialize the object.
| win.append(self._get_winner(distance_list, k)) | ||
| return win | ||
|
|
||
| def _get_winner(self, distance_list, k): |
There was a problem hiding this comment.
Why are you getting k here when you've defined it on init?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.