Conversation
| #open MAIL, "|mail msobolewska\@cfa.harvard.edu"; | ||
| #open MAIL, "|more"; #debug | ||
| open FILE, $afile; | ||
| while (<FILE>) { |
There was a problem hiding this comment.
ditto here, where does this while loop end?
| my $afile = "./.aacccdptalert"; | ||
| my $tfile = "./.aacccdptwait"; | ||
| my $afile = ".aacccdptalert"; | ||
| my $tfile = ".aacccdptwait"; |
There was a problem hiding this comment.
if we are no longer sending alerts for high temperature ccd then do we need this function?
There was a problem hiding this comment.
This is to be decided. Similarly, we also no longer send alerts for tank pressure.
|
|
||
| sub send_tank_red { | ||
| my $obstime = ${$hash{PMTANKP}}[0]; | ||
| if (! time_curr($obstime)) { |
There was a problem hiding this comment.
these two lines are commented out in check_state_test.pm, what's the reason for the difference here?
There was a problem hiding this comment.
They are commented in check_state_test.pm so that we can test with old telemetry.
There was a problem hiding this comment.
So they will be un-commented when we the changes are made?
There was a problem hiding this comment.
In check_state_test we always had these lines commented, I think? The idea was to be able to test on fabricated telemetry. In check_state.pm these lines are un-commented so that the alert checking happens only when real time data is flowing. In check_state_sim.pm (to be added for the SIMs) these lines will be un-commented, TEST in the subject and body of the messages will be replaced with SIM, and the mailing lists will be the same as in check_state.pm. Does is make sense?
There was a problem hiding this comment.
I've been using check_state_test.pm anytime we've had an anomaly and during recovery didn't need to send out alerts. check_state_no_alerts.pm is written in a way that still sends out alerts - I'm not sure what the original intention behind this was. It's fine for test to have the lines uncommented, will it still function if set during an anomaly? Or will we have to have a different way of not sending out alerts?
linamaria11
left a comment
linamaria11
left a comment
There was a problem hiding this comment.
Did my best to look for typos/spelling but all the msids started to float together when I got to snap_format.pm - I think they look good though. Do you have a sample of the resulting snapshot page?
| @@ -1208,18 +1425,16 @@ sub send_tank_yellow { | |||
| if (! time_curr($obstime)) { | |||
There was a problem hiding this comment.
ditto comment under send_tank_yellow
|
|
||
| sub send_tank_red { | ||
| my $obstime = ${$hash{PMTANKP}}[0]; | ||
| if (! time_curr($obstime)) { |
There was a problem hiding this comment.
So they will be un-commented when we the changes are made?
|
|
||
| $s .= sprintf " OBSID %5d EPState %4s\n", | ||
| ${$h{COBSRQID}}[1], ${$h{EPSTATE}}[1]; | ||
| $s .= sprintf "%52 sOBSID %5d EPState %4s\n", |
There was a problem hiding this comment.
is it okay for the %52 and s to be separated?
There was a problem hiding this comment.
No.. Thanks! Good catch.
|
Added:
|
2 participants
This branch contains updates related to the HRC swap to B-side electronics. In summary:
I also removed a number of obsolete commented lines from the code to make the code easier to read.
The following files most likely can be removed from the package (please confirm):
check_state_alerts.pmcheck_state_noalerts.pmsnaps2_alerts.parsnaps2_noalerts.parNeeds to be added:
testsfolder with test telemetry to work with the test package