feat: support custom selection dialog#56
Open
ductridev wants to merge 2 commits intochandrabezzo:mainfrom
Open
feat: support custom selection dialog#56ductridev wants to merge 2 commits intochandrabezzo:mainfrom
ductridev wants to merge 2 commits intochandrabezzo:mainfrom
Conversation
Owner
|
Hi @ductridev can you provide the proof of your changes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for a custom selection dialog via a new custom builder. An example usage of the custom builder is also provided.
Changes Made:
showCountryCodePickerDialog(commit 0dd5c35)Related Issues:
#52
Note:
showCountryCodePickerDialogwhileshowCountryCodePickerBottomSheetis not implemented yetcc: @chandrabezzo @MrRoy121