fix(rtl): keep dial code '+' on the left via LRM#68
Open
aradhwan wants to merge 1 commit intochandrabezzo:mainfrom
Open
fix(rtl): keep dial code '+' on the left via LRM#68aradhwan wants to merge 1 commit intochandrabezzo:mainfrom
aradhwan wants to merge 1 commit intochandrabezzo:mainfrom
Conversation
Wrap dial code with U+200E (LRM) in display strings to prevent bidi reordering in RTL. Refs chandrabezzo#67
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In RTL locales (e.g., Arabic), the dial code plus sign
+can jump to the right side of the digits due to Unicode bidi reordering. Users expect+to remain on the left (e.g.,+971).What this PR changes
_dialCodeLTRgetter that wrapsdialCodewith U+200E (LRM)._dialCodeLTRintoString()andtoLongString()so display strings render correctly in RTL.dialCodefield untouched (search/filter behavior unchanged).Rationale
LRM isolates the dial code as LTR, preventing bidi reordering in RTL UI while keeping API and data intact.
Screenshots
Related issue
Fixes #67
Testing
locale = ar.dialCode).Notes