Skip comments that return a 410 Gone error from github as well.#332
Draft
MoralCode wants to merge 1 commit into
Draft
Skip comments that return a 410 Gone error from github as well.#332MoralCode wants to merge 1 commit into
MoralCode wants to merge 1 commit into
Conversation
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Contributor
Author
|
manual functional test steps:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This includes a catch case for 410 GONE replies from github (as would appear in the comments endpoint when trying to fetch comments on issues where issues are disabled repo wide.
This PR fixes #226
Notes for Reviewers
Draft until fully tested
Target testing level: Manual Functional test
Signed commits