fix: allow --help to work without database connection#337
Closed
Suraj-H675 wants to merge 1 commit into
Closed
Conversation
Skip the test_db_connection and test_connection decorators when --help is passed. This allows users to run 'collectoss --help' and 'collectoss <command> --help' without requiring a database connection, which is useful for getting help during initial setup. Fixes #194 Signed-off-by: Suraj <surajh6705@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this solve?
Allows
collectoss --helpandcollectoss <command> --helpto work without requiring a database connection or internet connectivity. Previously, running--helpwould fail with "no way to get connection to the database" because thetest_db_connectionandtest_connectiondecorators were called even for help output.What changed and why?
Modified
test_connectionandtest_db_connectiondecorators incollectoss/application/cli/__init__.pyto skip their checks when--helpis passed. This allows users to get help text during initial setup before configuring the database.How was this tested?
ctx.params.get("help")is set by Click when--helpis passedChecklist
-sflag used on commit)This contribution was created with AI assistance, with human review and approval at each step.