Update the update_plugin_provider method and docs#35
Merged
charlesLoder merged 1 commit intomainfrom Sep 2, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the update_plugin_provider method signature to remove the redundant provider parameter and updates documentation to reflect the change. The method now implicitly uses this instead of requiring the provider instance to be passed as a parameter.
- Remove provider parameter from
update_plugin_providermethod since it always passesthis - Update documentation examples to use the simplified method call
- Fix code block language from
typescripttotsxin documentation
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/plugin/base_provider.tsx | Updates method signature to remove provider parameter and use implicit this |
| src/providers/userTokenProvider/index.tsx | Updates method call to use new signature without parameter |
| stories/docs/creating-a-provider.mdx | Updates documentation examples and fixes code block language |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
33fe1cd to
7dbb0d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #25
Goes beyond fixing the typo, and updates the
update_plugin_providermethod