Skip to content

Update the update_plugin_provider method and docs#35

Merged
charlesLoder merged 1 commit intomainfrom
issue-25/update-plugin-provider
Sep 2, 2025
Merged

Update the update_plugin_provider method and docs#35
charlesLoder merged 1 commit intomainfrom
issue-25/update-plugin-provider

Conversation

@charlesLoder
Copy link
Owner

Closes #25

Goes beyond fixing the typo, and updates the update_plugin_provider method

@charlesLoder charlesLoder requested a review from Copilot September 2, 2025 17:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the update_plugin_provider method signature to remove the redundant provider parameter and updates documentation to reflect the change. The method now implicitly uses this instead of requiring the provider instance to be passed as a parameter.

  • Remove provider parameter from update_plugin_provider method since it always passes this
  • Update documentation examples to use the simplified method call
  • Fix code block language from typescript to tsx in documentation

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/plugin/base_provider.tsx Updates method signature to remove provider parameter and use implicit this
src/providers/userTokenProvider/index.tsx Updates method call to use new signature without parameter
stories/docs/creating-a-provider.mdx Updates documentation examples and fixes code block language

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@charlesLoder charlesLoder force-pushed the issue-25/update-plugin-provider branch from 33fe1cd to 7dbb0d4 Compare September 2, 2025 17:14
@charlesLoder charlesLoder merged commit 5249e29 into main Sep 2, 2025
3 checks passed
@charlesLoder charlesLoder deleted the issue-25/update-plugin-provider branch September 2, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typo: creating a provider

2 participants