Merged
Conversation
- Add new extractor module with readable content extraction using readability - Implement HTML sanitization with ammonia and link resolution - Add language detection using whatlang - Include content rejection filters for low-quality content - Add comprehensive test coverage with fixtures - Add fuzzing infrastructure to test robustness - Update dependencies: readability, kuchiki, ammonia, whatlang, linkify - Fix auth middleware test configuration to use proper config loading Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-ac62a9cb-5ac8-46b1-8c5f-85827e067240
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements a comprehensive content extraction and normalization system for processing web pages. This system extracts readable content from HTML, sanitizes it for security, detects language, and filters out low-quality content.
Fixes #22
Changes Made
Detailed Changes
Testing
make test)Test Commands Run
Code Quality
make fmt)make lint)make check)Database Changes
make preparerun after schema changesBreaking Changes
Breaking Changes Details
Deployment Notes
Special Deployment Steps
New dependencies need to be installed:
readability,ammonia,whatlang,kuchiki,linkify,proptestDocumentation
Reviewer Checklist
Additional Notes
PageResponsetype