Update and rename github.go to BTC HTML#815
Open
btchtml-sketch wants to merge 1 commit intocharmbracelet:proposals-updatefrom
Open
Update and rename github.go to BTC HTML#815btchtml-sketch wants to merge 1 commit intocharmbracelet:proposals-updatefrom
btchtml-sketch wants to merge 1 commit intocharmbracelet:proposals-updatefrom
Conversation
|
It's generally best not to create a PR that hardcodes the project to your personal profile. It's important that the code remains configurable and not tied to any specific user. These functions are designed to validate a Github URL and find README in a repository via a provided Github Repository URL string. You can view a public Github Repository README file using the glow CLI So if you have a Public Repository README file on your profile, you would use Additionally, Your code contains multiple syntax errors and won't compile as-is. You branch is also quite a bit behind master . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BTC HTML
Describe your changes
Related issue/discussion:
Checklist before requesting a review
CONTRIBUTING.mdIf this is a feature