feat(pager): add incremental search functionality#873
Open
glogiotatidis wants to merge 1 commit intocharmbracelet:masterfrom
Open
feat(pager): add incremental search functionality#873glogiotatidis wants to merge 1 commit intocharmbracelet:masterfrom
glogiotatidis wants to merge 1 commit intocharmbracelet:masterfrom
Conversation
glogiotatidis
requested review from
aymanbagabas and
raphamorim
and removed request for
a team
Add less-style search to the pager with the following features: - Press / to start searching, type query, Enter to confirm - n/N to navigate between matches - Smart case sensitivity (case-insensitive unless query has uppercase) - Search highlighting with current match distinction - Preserves ANSI formatting in highlighted lines Fixes charmbracelet#834, charmbracelet#420, charmbracelet#323, charmbracelet#183
glogiotatidis
force-pushed
the
feature/pager-search
branch
from
ed01ceb to
267c6c4
Compare
|
Hi guys, any updates on that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add search capability to the pager view:
Performance optimizations:
This was vibe coded, but tested and reviewed by a human.
Fixes #834
I have read
CONTRIBUTING.md.I have created a discussion that was approved by a maintainer (for new features).
There is issue TUI should support less-style searches #834. It's useful for me so I built it.