fix: use true color for code_block rendering if support detected#891
Open
aslpavel wants to merge 1 commit intocharmbracelet:masterfrom
Open
fix: use true color for code_block rendering if support detected#891aslpavel wants to merge 1 commit intocharmbracelet:masterfrom
code_block rendering if support detected#891aslpavel wants to merge 1 commit intocharmbracelet:masterfrom
Conversation
aslpavel
requested review from
meowgorithm and
raphamorim
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug in how
code_blockis rendered, currently 256 colors palette is used regardless whether true color is detected or not. To reproduce just render any markdown document which contains ```language... colors will be off because they are quantized to nearest color from 256 palette.Here is example is before (top) and after (bottom)
This change correctly initializes true color in
Chromalibrary