Ensure that the style config path is expanded where it is used.#902
Open
hobeone wants to merge 1 commit intocharmbracelet:masterfrom
Open
Ensure that the style config path is expanded where it is used.#902hobeone wants to merge 1 commit intocharmbracelet:masterfrom
hobeone wants to merge 1 commit intocharmbracelet:masterfrom
Conversation
Addresses issue charmbracelet#776 Also adds a test to ensure it expands environment variables in the file path.
hobeone
requested review from
meowgorithm and
raphamorim
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue #776
Also adds a test to ensure it expands environment variables in the file path.
CONTRIBUTING.md.Example config snippet:
style: "~/.config/glow/tokyo_night.json"
Before fix:
After Fix: