Add RTL/BiDi support for Arabic, Hebrew, and other RTL scripts#923
Open
Tirador1 wants to merge 1 commit intocharmbracelet:masterfrom
Open
Add RTL/BiDi support for Arabic, Hebrew, and other RTL scripts#923Tirador1 wants to merge 1 commit intocharmbracelet:masterfrom
Tirador1 wants to merge 1 commit intocharmbracelet:masterfrom
Conversation
Fixes charmbracelet#725. Terminals like Windows Terminal render text strictly left-to-right without applying the Unicode BiDi algorithm. This causes Arabic and other RTL text to appear with reversed characters and wrong word order. This adds a post-render BiDi reordering pass that: - Strips ANSI escape codes, applies the Unicode BiDi algorithm (golang.org/x/text/unicode/bidi) per line, then reconstructs the styled output with correct visual ordering - Reverses characters within RTL runs and mirrors bracket pairs - Preserves LTR runs (English, code) unchanged - Has zero overhead for pure-LTR content (fast-path check) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #725.
containsRTLcheckgolang.org/x/text/unicode/bidiwhich is already a transitive dependencyBefore
Arabic text appears with reversed characters and wrong word order:
After
Arabic text displays correctly when read right-to-left:
Changes
bidi.gomain.gobidiReorder(out)after glamour rendersTest plan