feat: Allow setting rows/cols for dimensions instead of just pixels#763
Open
DaltonSW wants to merge 4 commits into
Open
feat: Allow setting rows/cols for dimensions instead of just pixels#763DaltonSW wants to merge 4 commits into
DaltonSW wants to merge 4 commits into
Conversation
Member
|
@DaltonSW mind fixing the build errors? |
Adds `Set Rows`/`Set Columns` commands to size the terminal in character cells instead of pixels. The pixel size is derived by probing the live xterm.js terminal's own fit/measurement APIs and iterating to an exact match, so it stays correct across font/theme changes without depending on any of xterm.js's private internals.
Adds demo tapes for Set Rows and Set Columns (individually and combined) and documents them in examples/settings/README.md, matching the existing width/height example pattern.
Contributor
Author
|
@meowgorithm Done! I think I misunderstood LFS stuff. 😅 Did you want me to clean up any of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Set Rows/Set Columnscommands to size the terminal in charactercells instead of pixels. The pixel size is derived by probing the live
xterm.js terminal's own fit/measurement APIs and iterating to an exact
match, so it stays correct across font/theme changes without depending
on any of xterm.js's private internals.
CONTRIBUTING.md.