Update references to a maintained version of the tooltips plugin#1206
Open
lukbukkit wants to merge 2 commits intochartist-js:mainfrom
Open
Update references to a maintained version of the tooltips plugin#1206lukbukkit wants to merge 2 commits intochartist-js:mainfrom
lukbukkit wants to merge 2 commits intochartist-js:mainfrom
Conversation
Upgraded to the latest version of grunt-sass, because grunt-sass 1.1.0 didn't support NodeJS v12
Using prebuilt files, because bower is deprecated since 2017
f818b93 to
3173275
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I created a fork of the tooltips plugin a while ago and currently I'm maintaining it.
A user of my fork pointed out to me (chartist-plugin-tooltip#5), that the website still refers to the old version. It would be nice if we could update the references on the chartist webpage.
To edit the website I had to upgrade
grunt-sassto version 3.1.0, otherwise this wouldn't be compatible with NodeJS 12. I included distribution files of my plugin directly into the repository, because bower is deprecated and I didn't want to list my plugin there if you shouldn't use it anymore.And by the way thanks for your work on Chartist, it's my first choice for charting.